[llvm] r224782 - Finish removing DestroySource.

Hans Wennborg hans at chromium.org
Tue Feb 24 17:03:17 PST 2015


On Tue, Feb 24, 2015 at 4:58 PM, Sean Silva <chisophugis at gmail.com> wrote:
>
>
> On Tue, Feb 24, 2015 at 4:39 PM, Hans Wennborg <hans at chromium.org> wrote:
>>
>> On Tue, Feb 24, 2015 at 3:46 PM, Filip Pizlo <fpizlo at apple.com> wrote:
>> > Proposed fix:
>>
>> > -                         unsigned Unused, char **OutMessages) {
>> > +                         LLVMLinkerMode Unused, char **OutMessages) {
>>
>> Do we really need to use the enum in the function prototype? Peter's
>> message suggests this might require a bindings update. The enumerators
>> should convert to unsigned anyway, right?
>
>
> IMO, the safest thing to do would be to revert the patch for the release. It
> was just a cleanup anyway.

Yeah, that's kind of what I'm thinking at this point. It maintains
status quo and allows us to deal with this later.



More information about the llvm-commits mailing list