[llvm] r224782 - Finish removing DestroySource.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Feb 24 17:03:31 PST 2015


On 24 February 2015 at 19:58, Sean Silva <chisophugis at gmail.com> wrote:
>
>
> On Tue, Feb 24, 2015 at 4:39 PM, Hans Wennborg <hans at chromium.org> wrote:
>>
>> On Tue, Feb 24, 2015 at 3:46 PM, Filip Pizlo <fpizlo at apple.com> wrote:
>> > Proposed fix:
>>
>> > -                         unsigned Unused, char **OutMessages) {
>> > +                         LLVMLinkerMode Unused, char **OutMessages) {
>>
>> Do we really need to use the enum in the function prototype? Peter's
>> message suggests this might require a bindings update. The enumerators
>> should convert to unsigned anyway, right?
>
>
> IMO, the safest thing to do would be to revert the patch for the release. It
> was just a cleanup anyway.

That patch was follow by quite a few changes to lib/Linker that depend on it.

Cheers,
Rafael



More information about the llvm-commits mailing list