[llvm] r224782 - Finish removing DestroySource.

Sean Silva chisophugis at gmail.com
Tue Feb 24 16:58:08 PST 2015


On Tue, Feb 24, 2015 at 4:39 PM, Hans Wennborg <hans at chromium.org> wrote:

> On Tue, Feb 24, 2015 at 3:46 PM, Filip Pizlo <fpizlo at apple.com> wrote:
> > Proposed fix:
>
> > -                         unsigned Unused, char **OutMessages) {
> > +                         LLVMLinkerMode Unused, char **OutMessages) {
>
> Do we really need to use the enum in the function prototype? Peter's
> message suggests this might require a bindings update. The enumerators
> should convert to unsigned anyway, right?
>

IMO, the safest thing to do would be to revert the patch for the release.
It was just a cleanup anyway.

-- Sean Silva


>
> >
> > OK to commit?
> >
> > -Filip
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150224/2ee17c9e/attachment.html>


More information about the llvm-commits mailing list