[PATCH] Add an experimental Sanitizer Windows builder

[Zachary Turner]

Galina: Is 0.8.10 ok?  I ran "pip update" and it automatically gave me
0.8.10.  I remember somewhere reading there was a compatibility issue with
0.8.10, but I can't find it anywhere now.

On Tue Feb 17 2015 at 11:06:42 AM Galina <gkistanova at gmail.com> wrote:

> The patch looks good to me, assuming you will fix the getLLDBSource vs.
> getSource and remove unused python_source_dir.
>
> Please note that you will need a buildslave 0.8.9 for this builder.
>
>
> ================
> Comment at: zorg/buildbot/builders/SanitizerBuilderWindows.py:35
> @@ +34,3 @@
> +            # Source directory containing a built python
> +            python_source_dir=r'C:/src/python',
> +
> ----------------
> This param seems unused. Could you remove if you do not need it, please?
>
> ================
> Comment at: zorg/buildbot/builders/SanitizerBuilderWindows.py:53
> @@ +52,3 @@
> +
> +    f = getLLDBSource(f,'llvm')
> +
> ----------------
> Is this correct? Or it should be getSource here?
>
> ================
> Comment at: zorg/buildbot/builders/SanitizerBuilderWindows.py:71
> @@ +70,3 @@
> +    f.addStep(batch_file_download.BatchFileDownload(name='cmakegen',
> +                                command=[cmake, "-G", "Ninja", "../llvm",
> +                                         "-DCMAKE_BUILD_TYPE="+config,
> ----------------
> Usage of getVisualStudioEnvironment effectively mean you will be running
> at least buildslave 0.8.9. In this case, it will create temp batch by
> itself, so, there is no real need in explicit batch-ing. You can just use
> the command directly.
>
> This is not a show stopper for this patch, though.
>
> http://reviews.llvm.org/D7675
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150217/571850bd/attachment.html>