<div dir="ltr">Galina: Is 0.8.10 ok?  I ran "pip update" and it automatically gave me 0.8.10.  I remember somewhere reading there was a compatibility issue with 0.8.10, but I can't find it anywhere now.<br></div><br><div class="gmail_quote">On Tue Feb 17 2015 at 11:06:42 AM Galina <<a href="mailto:gkistanova@gmail.com">gkistanova@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The patch looks good to me, assuming you will fix the getLLDBSource vs. getSource and remove unused python_source_dir.<br>
<br>
Please note that you will need a buildslave 0.8.9 for this builder.<br>
<br>
<br>
================<br>
Comment at: zorg/buildbot/builders/<u></u>SanitizerBuilderWindows.py:35<br>
@@ +34,3 @@<br>
+            # Source directory containing a built python<br>
+            python_source_dir=r'C:/src/<u></u>python',<br>
+<br>
----------------<br>
This param seems unused. Could you remove if you do not need it, please?<br>
<br>
================<br>
Comment at: zorg/buildbot/builders/<u></u>SanitizerBuilderWindows.py:53<br>
@@ +52,3 @@<br>
+<br>
+    f = getLLDBSource(f,'llvm')<br>
+<br>
----------------<br>
Is this correct? Or it should be getSource here?<br>
<br>
================<br>
Comment at: zorg/buildbot/builders/<u></u>SanitizerBuilderWindows.py:71<br>
@@ +70,3 @@<br>
+    f.addStep(batch_file_download.<u></u>BatchFileDownload(name='<u></u>cmakegen',<br>
+                                command=[cmake, "-G", "Ninja", "../llvm",<br>
+                                         "-DCMAKE_BUILD_TYPE="+config,<br>
----------------<br>
Usage of getVisualStudioEnvironment effectively mean you will be running at least buildslave 0.8.9. In this case, it will create temp batch by itself, so, there is no real need in explicit batch-ing. You can just use the command directly.<br>
<br>
This is not a show stopper for this patch, though.<br>
<br>
<a href="http://reviews.llvm.org/D7675" target="_blank">http://reviews.llvm.org/D7675</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/<u></u>settings/panel/<u></u>emailpreferences/</a><br>
<br>
<br>
</blockquote></div>