[PATCH] Add an experimental Sanitizer Windows builder

[Galina]

The patch looks good to me, assuming you will fix the getLLDBSource vs. getSource and remove unused python_source_dir.

Please note that you will need a buildslave 0.8.9 for this builder.


================
Comment at: zorg/buildbot/builders/SanitizerBuilderWindows.py:35
@@ +34,3 @@
+            # Source directory containing a built python
+            python_source_dir=r'C:/src/python',
+
----------------
This param seems unused. Could you remove if you do not need it, please?

================
Comment at: zorg/buildbot/builders/SanitizerBuilderWindows.py:53
@@ +52,3 @@
+
+    f = getLLDBSource(f,'llvm')
+
----------------
Is this correct? Or it should be getSource here?

================
Comment at: zorg/buildbot/builders/SanitizerBuilderWindows.py:71
@@ +70,3 @@
+    f.addStep(batch_file_download.BatchFileDownload(name='cmakegen',
+                                command=[cmake, "-G", "Ninja", "../llvm",
+                                         "-DCMAKE_BUILD_TYPE="+config,
----------------
Usage of getVisualStudioEnvironment effectively mean you will be running at least buildslave 0.8.9. In this case, it will create temp batch by itself, so, there is no real need in explicit batch-ing. You can just use the command directly.

This is not a show stopper for this patch, though.

http://reviews.llvm.org/D7675

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/