[PATCH] [lld] Remove fragile regex from test

[Rui Ueyama]

On Mon, Jan 12, 2015 at 3:39 PM, Greg Fitzgerald <garious at gmail.com> wrote:

> REPOSITORY
>   rL LLVM
>
> ================
> Comment at: test/elf/dynamic-undef.test:30
> @@ +29,3 @@
> +EXEC: Undefined symbol:
> +EXEC-NEXT: shared.so-x86-64: puts
> +SHLIB: Undefined symbol:
> ----------------
> ruiu wrote:
> > garious wrote:
> > > ruiu wrote:
> > > > I don't fully understand why now you need to split this into two
> lines. If "Undefined symbol" is not on the same line as "shared.so-x86-64:
> puts", why the previous test succeeded?
> > > I suspect FileCheck looks for "no more than one newline".  How about
> {{.+[\\/]}} instead?
> > Maybe
> >
> >   EXEC: Undefined symbol: {{.*}}/shared.so-x86-64: puts
> >
> > is enough?
> Would that work if cross-compiling on Windows?
>

Good point. LGTM.


>
> http://reviews.llvm.org/D6937
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150112/ef0ff58e/attachment.html>