[PATCH] [lld] Remove fragile regex from test
Greg Fitzgerald
garious at gmail.com
Mon Jan 12 15:39:15 PST 2015
REPOSITORY
rL LLVM
================
Comment at: test/elf/dynamic-undef.test:30
@@ +29,3 @@
+EXEC: Undefined symbol:
+EXEC-NEXT: shared.so-x86-64: puts
+SHLIB: Undefined symbol:
----------------
ruiu wrote:
> garious wrote:
> > ruiu wrote:
> > > I don't fully understand why now you need to split this into two lines. If "Undefined symbol" is not on the same line as "shared.so-x86-64: puts", why the previous test succeeded?
> > I suspect FileCheck looks for "no more than one newline". How about {{.+[\\/]}} instead?
> Maybe
>
> EXEC: Undefined symbol: {{.*}}/shared.so-x86-64: puts
>
> is enough?
Would that work if cross-compiling on Windows?
http://reviews.llvm.org/D6937
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list