<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Jan 12, 2015 at 3:39 PM, Greg Fitzgerald <span dir="ltr"><<a href="mailto:garious@gmail.com" target="_blank">garious@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">REPOSITORY<br>
  rL LLVM<br>
<br>
================<br>
Comment at: test/elf/dynamic-undef.test:30<br>
@@ +29,3 @@<br>
</span><span class="">+EXEC: Undefined symbol:<br>
+EXEC-NEXT: shared.so-x86-64: puts<br>
+SHLIB: Undefined symbol:<br>
</span>----------------<br>
<span class="">ruiu wrote:<br>
> garious wrote:<br>
> > ruiu wrote:<br>
> > > I don't fully understand why now you need to split this into two lines. If "Undefined symbol" is not on the same line as "shared.so-x86-64: puts", why the previous test succeeded?<br>
> > I suspect FileCheck looks for "no more than one newline".  How about {{.+[\\/]}} instead?<br>
> Maybe<br>
><br>
>   EXEC: Undefined symbol: {{.*}}/shared.so-x86-64: puts<br>
><br>
> is enough?<br>
</span>Would that work if cross-compiling on Windows?<br></blockquote><div><br></div><div>Good point. LGTM.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
<a href="http://reviews.llvm.org/D6937" target="_blank">http://reviews.llvm.org/D6937</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</div></div></blockquote></div><br></div></div>