[PATCH] Move ownership of GCStrategy objects to LLVMContext

[Sean Silva]

On Thu, Jan 8, 2015 at 10:33 AM, Philip Reames <listmail at philipreames.com>
wrote:

> ping
>
> This is blocking work I'd like to get in before we cut 3.6.  The only part
> left to review is having someone look over the ownership changes for
> GCStrategy and make sure I haven't missed something. The code has already
> been reviewed, just not by someone who felt comfortable with the ownership
> changes.
>
> If I haven't received a response on the ownership changes by tomorrow, I'm
> going to go ahead and submit.  I know this is not generally accepted
> practice, but given the code has been reviewed, if not with the emphasis
> I'd prefer, and that the change itself is fairly simple,  I'm going to
> submit unless someone objects.


I object. I don't think anybody has LGTM'd the layering. I assume you
originally CC'd Chandler and Nick precisely for reviewing this aspect of
the patch, and neither seems to have chimed in yet and LGTM'd the layering.

-- Sean Silva


>
>
> Philip
>
>
> On 01/07/2015 12:03 PM, Philip Reames wrote:
>
>> Address Sanjoy's style comments and add some header includes to fix a
>> build issue on TOT.
>>
>> ping - specifically regards to the ownership, everything else has been
>> reviewed
>>
>>
>> http://reviews.llvm.org/D6811
>>
>> Files:
>>    include/llvm/CodeGen/GCMetadata.h
>>    include/llvm/CodeGen/GCStrategy.h
>>    include/llvm/IR/Function.h
>>    lib/CodeGen/GCMetadata.cpp
>>    lib/IR/Function.cpp
>>    lib/IR/LLVMContextImpl.cpp
>>    lib/IR/LLVMContextImpl.h
>>
>> EMAIL PREFERENCES
>>    http://reviews.llvm.org/settings/panel/emailpreferences/
>>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150108/b7b60007/attachment.html>