<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jan 8, 2015 at 10:33 AM, Philip Reames <span dir="ltr"><<a href="mailto:listmail@philipreames.com" target="_blank">listmail@philipreames.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">ping<br>
<br>
This is blocking work I'd like to get in before we cut 3.6.  The only part left to review is having someone look over the ownership changes for GCStrategy and make sure I haven't missed something. The code has already been reviewed, just not by someone who felt comfortable with the ownership changes.<br>
<br>
If I haven't received a response on the ownership changes by tomorrow, I'm going to go ahead and submit.  I know this is not generally accepted practice, but given the code has been reviewed, if not with the emphasis I'd prefer, and that the change itself is fairly simple,  I'm going to submit unless someone objects.</blockquote><div><br></div><div>I object. I don't think anybody has LGTM'd the layering. I assume you originally CC'd Chandler and Nick precisely for reviewing this aspect of the patch, and neither seems to have chimed in yet and LGTM'd the layering.</div><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="HOEnZb"><font color="#888888"><br>
<br>
Philip</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
On 01/07/2015 12:03 PM, Philip Reames wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Address Sanjoy's style comments and add some header includes to fix a build issue on TOT.<br>
<br>
ping - specifically regards to the ownership, everything else has been reviewed<br>
<br>
<br>
<a href="http://reviews.llvm.org/D6811" target="_blank">http://reviews.llvm.org/D6811</a><br>
<br>
Files:<br>
   include/llvm/CodeGen/<u></u>GCMetadata.h<br>
   include/llvm/CodeGen/<u></u>GCStrategy.h<br>
   include/llvm/IR/Function.h<br>
   lib/CodeGen/GCMetadata.cpp<br>
   lib/IR/Function.cpp<br>
   lib/IR/LLVMContextImpl.cpp<br>
   lib/IR/LLVMContextImpl.h<br>
<br>
EMAIL PREFERENCES<br>
   <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/<u></u>settings/panel/<u></u>emailpreferences/</a><br>
</blockquote>
<br></div></div><div class="HOEnZb"><div class="h5">
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div>