[PATCH] Move ownership of GCStrategy objects to LLVMContext

Philip Reames listmail at philipreames.com
Thu Jan 8 10:33:16 PST 2015


ping

This is blocking work I'd like to get in before we cut 3.6.  The only 
part left to review is having someone look over the ownership changes 
for GCStrategy and make sure I haven't missed something. The code has 
already been reviewed, just not by someone who felt comfortable with the 
ownership changes.

If I haven't received a response on the ownership changes by tomorrow, 
I'm going to go ahead and submit.  I know this is not generally accepted 
practice, but given the code has been reviewed, if not with the emphasis 
I'd prefer, and that the change itself is fairly simple,  I'm going to 
submit unless someone objects.

Philip

On 01/07/2015 12:03 PM, Philip Reames wrote:
> Address Sanjoy's style comments and add some header includes to fix a build issue on TOT.
>
> ping - specifically regards to the ownership, everything else has been reviewed
>
>
> http://reviews.llvm.org/D6811
>
> Files:
>    include/llvm/CodeGen/GCMetadata.h
>    include/llvm/CodeGen/GCStrategy.h
>    include/llvm/IR/Function.h
>    lib/CodeGen/GCMetadata.cpp
>    lib/IR/Function.cpp
>    lib/IR/LLVMContextImpl.cpp
>    lib/IR/LLVMContextImpl.h
>
> EMAIL PREFERENCES
>    http://reviews.llvm.org/settings/panel/emailpreferences/




More information about the llvm-commits mailing list