[PATCH] [ARM] More rigorous testing of build attribute encoding/decoding

Charlie Turner charlie.turner at arm.com
Thu Nov 20 09:03:11 PST 2014


Address Tim's comments.

 * I have rearranged the tests into files such as attribute-n.s, which contains tests for attributes which can take on value n.
 * I am now testing the descriptions of these attributes as well. My point was that I feel you still need the ABI document with some of these abbreviations because they can be a tad cryptic. I do concede that's no excuse to ignore testing what we have however :)

Thank you very much for your review Tim!

http://reviews.llvm.org/D6319

Files:
  test/tools/llvm-readobj/ARM/attribute-0.s
  test/tools/llvm-readobj/ARM/attribute-1.s
  test/tools/llvm-readobj/ARM/attribute-10.s
  test/tools/llvm-readobj/ARM/attribute-11.s
  test/tools/llvm-readobj/ARM/attribute-12.s
  test/tools/llvm-readobj/ARM/attribute-13.s
  test/tools/llvm-readobj/ARM/attribute-136.s
  test/tools/llvm-readobj/ARM/attribute-14.s
  test/tools/llvm-readobj/ARM/attribute-15.s
  test/tools/llvm-readobj/ARM/attribute-2.s
  test/tools/llvm-readobj/ARM/attribute-3.s
  test/tools/llvm-readobj/ARM/attribute-4.s
  test/tools/llvm-readobj/ARM/attribute-5.s
  test/tools/llvm-readobj/ARM/attribute-6.s
  test/tools/llvm-readobj/ARM/attribute-7.s
  test/tools/llvm-readobj/ARM/attribute-8.s
  test/tools/llvm-readobj/ARM/attribute-9.s
  test/tools/llvm-readobj/ARM/attribute-A.s
  test/tools/llvm-readobj/ARM/attribute-M.s
  test/tools/llvm-readobj/ARM/attribute-R.s
  test/tools/llvm-readobj/ARM/attribute-S.s
  test/tools/llvm-readobj/ARM/attributes.s
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6319.16437.patch
Type: text/x-patch
Size: 50936 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141120/9b254697/attachment.bin>


More information about the llvm-commits mailing list