[PATCH] [ARM] More rigorous testing of build attribute encoding/decoding

Tim Northover t.p.northover at gmail.com
Thu Nov 20 10:39:29 PST 2014


Hi Charlie,

Just spotted one potential issue looking through the tests:

================
Comment at: test/tools/llvm-readobj/ARM/attribute-136.s:4-7
@@ +3,6 @@
+@ RUN:   | llvm-readobj -arm-attributes - | FileCheck %s --check-prefix=CHECK-OBJ
+.eabi_attribute  Tag_compatibility, 136, "Foo Corp"
+ at CHECK:   .eabi_attribute 32, 136
+ at CHECK-OBJ: Tag: 32
+ at CHECK-OBJ-NEXT: Value: 136, FOO CORP
+ at CHECK-OBJ-NEXT: TagName: compatibility
----------------
What's doing the capitalisation here? It seems highly suspect (not mentioned in the ABI as far as I can tell, and gets into sticky locale questions).

http://reviews.llvm.org/D6319






More information about the llvm-commits mailing list