[PATCH] [ARM] More rigorous testing of build attribute encoding/decoding

[Tim Northover]

Hi Charlie,

> The description fields of tags are not being tested in this patch whereas they were being tested in test/tools/llvm-readobj/ARM/attributes.s (the removed file). I don't think it is useful to test the hard-coded strings in tools/llvm-readobj/ARMAttributeParser.cpp.

I disagree with this. Or at least I think that functionality should exist somewhere (I don't want to need the ELF ABI reference open just to tell if the attributes are sane) and if it is present it should be tested. Comments during normal asm emission would be nice.

Other than that, the tests are .s files rather than .ll.

I'm also a bit worried by all the extra processes this will spawn. How about splitting them by value (at least the numeric ones): attributes-0.s, attributes-1.s etc?

Cheers.

Tim.

http://reviews.llvm.org/D6319