[llvm] r192745 - Support/FileSystem.h: Remove a trailing comma in enum file_magic::Impl.

[Rui Ueyama]

Ooh, I did add the trailing comma! :/ Sorry about that.


On Tue, Oct 15, 2013 at 4:23 PM, NAKAMURA Takumi <geek4civic at gmail.com>wrote:

> Ueyama san,
>
> In r192742, you stripped a trailing comma to add a member;
>
> -    pecoff_executable         ///< PECOFF executable file
> +    pecoff_executable,        ///< PECOFF executable file
> +    windows_resource,         ///< Windows compiled resource file (.rc)
>
> The standard C++03 requires not to add a trailing comma in enumerator
> list, FYI.
>
> ...Takumi
>
> 2013/10/16 Rui Ueyama <ruiu at google.com>:
> > Just curious, should we remove a trailing comma? Looks like the coding
> > standard does not say anything about it, and because I did not add the
> last
> > comma (the previous line already have had it), it had not been causing
> any
> > issues.
> >
> >
> > On Tue, Oct 15, 2013 at 4:01 PM, NAKAMURA Takumi <geek4civic at gmail.com>
> > wrote:
> >>
> >> Author: chapuni
> >> Date: Tue Oct 15 18:01:44 2013
> >> New Revision: 192745
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=192745&view=rev
> >> Log:
> >> Support/FileSystem.h: Remove a trailing comma in enum file_magic::Impl.
> >>
> >> Modified:
> >>     llvm/trunk/include/llvm/Support/FileSystem.h
> >>
> >> Modified: llvm/trunk/include/llvm/Support/FileSystem.h
> >> URL:
> >>
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/FileSystem.h?rev=192745&r1=192744&r2=192745&view=diff
> >>
> >>
> ==============================================================================
> >> --- llvm/trunk/include/llvm/Support/FileSystem.h (original)
> >> +++ llvm/trunk/include/llvm/Support/FileSystem.h Tue Oct 15 18:01:44
> 2013
> >> @@ -239,7 +239,7 @@ struct file_magic {
> >>      macho_universal_binary,   ///< Mach-O universal binary
> >>      coff_object,              ///< COFF object file
> >>      pecoff_executable,        ///< PECOFF executable file
> >> -    windows_resource,         ///< Windows compiled resource file (.rc)
> >> +    windows_resource          ///< Windows compiled resource file (.rc)
> >>    };
> >>
> >>    bool is_object() const {
> >>
> >>
> >> _______________________________________________
> >> llvm-commits mailing list
> >> llvm-commits at cs.uiuc.edu
> >> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131015/2abe6db2/attachment.html>