<div dir="ltr">Ooh, I did add the trailing comma! :/ Sorry about that.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Oct 15, 2013 at 4:23 PM, NAKAMURA Takumi <span dir="ltr"><<a href="mailto:geek4civic@gmail.com" target="_blank">geek4civic@gmail.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Ueyama san,<br>
<br>
In r192742, you stripped a trailing comma to add a member;<br>
<br>
-    pecoff_executable         ///< PECOFF executable file<br>
+    pecoff_executable,        ///< PECOFF executable file<br>
<div class="im">+    windows_resource,         ///< Windows compiled resource file (.rc)<br>
<br>
</div>The standard C++03 requires not to add a trailing comma in enumerator list, FYI.<br>
<br>
...Takumi<br>
<br>
2013/10/16 Rui Ueyama <<a href="mailto:ruiu@google.com">ruiu@google.com</a>>:<br>
<div class="HOEnZb"><div class="h5">> Just curious, should we remove a trailing comma? Looks like the coding<br>
> standard does not say anything about it, and because I did not add the last<br>
> comma (the previous line already have had it), it had not been causing any<br>
> issues.<br>
><br>
><br>
> On Tue, Oct 15, 2013 at 4:01 PM, NAKAMURA Takumi <<a href="mailto:geek4civic@gmail.com">geek4civic@gmail.com</a>><br>
> wrote:<br>
>><br>
>> Author: chapuni<br>
>> Date: Tue Oct 15 18:01:44 2013<br>
>> New Revision: 192745<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=192745&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=192745&view=rev</a><br>
>> Log:<br>
>> Support/FileSystem.h: Remove a trailing comma in enum file_magic::Impl.<br>
>><br>
>> Modified:<br>
>>     llvm/trunk/include/llvm/Support/FileSystem.h<br>
>><br>
>> Modified: llvm/trunk/include/llvm/Support/FileSystem.h<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/FileSystem.h?rev=192745&r1=192744&r2=192745&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/FileSystem.h?rev=192745&r1=192744&r2=192745&view=diff</a><br>


>><br>
>> ==============================================================================<br>
>> --- llvm/trunk/include/llvm/Support/FileSystem.h (original)<br>
>> +++ llvm/trunk/include/llvm/Support/FileSystem.h Tue Oct 15 18:01:44 2013<br>
>> @@ -239,7 +239,7 @@ struct file_magic {<br>
>>      macho_universal_binary,   ///< Mach-O universal binary<br>
>>      coff_object,              ///< COFF object file<br>
>>      pecoff_executable,        ///< PECOFF executable file<br>
>> -    windows_resource,         ///< Windows compiled resource file (.rc)<br>
>> +    windows_resource          ///< Windows compiled resource file (.rc)<br>
>>    };<br>
>><br>
>>    bool is_object() const {<br>
>><br>
>><br>
>> _______________________________________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
><br>
</div></div></blockquote></div><br></div>