[llvm] r192745 - Support/FileSystem.h: Remove a trailing comma in enum file_magic::Impl.

Vincent Lejeune vljn at ovi.com
Tue Oct 15 16:29:21 PDT 2013


clang was spamming a warning during compilation :
warning: commas at the end of enumerator lists are a C++11 extension [-Wc++11-extensions]
Built went fine though.

>________________________________
> De : Rui Ueyama <ruiu at google.com>
>À : NAKAMURA Takumi <geek4civic at gmail.com> 
>Cc : Commit Messages and Patches for LLVM <llvm-commits at cs.uiuc.edu> 
>Envoyé le : Mercredi 16 octobre 2013 1h13
>Objet : Re: [llvm] r192745 - Support/FileSystem.h: Remove a trailing comma in    enum file_magic::Impl.
> 
>
>
>Just curious, should we remove a trailing comma? Looks like the coding standard does not say anything about it, and because I did not add the last comma (the previous line already have had it), it had not been causing any issues.
>
>
>
>On Tue, Oct 15, 2013 at 4:01 PM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
>
>Author: chapuni
>>Date: Tue Oct 15 18:01:44 2013
>>New Revision: 192745
>>
>>URL: http://llvm.org/viewvc/llvm-project?rev=192745&view=rev
>>Log:
>>Support/FileSystem.h: Remove a trailing comma in enum file_magic::Impl.
>>
>>Modified:
>>    llvm/trunk/include/llvm/Support/FileSystem.h
>>
>>Modified: llvm/trunk/include/llvm/Support/FileSystem.h
>>URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/FileSystem.h?rev=192745&r1=192744&r2=192745&view=diff
>>==============================================================================
>>--- llvm/trunk/include/llvm/Support/FileSystem.h (original)
>>+++ llvm/trunk/include/llvm/Support/FileSystem.h Tue Oct 15 18:01:44 2013
>>@@ -239,7 +239,7 @@ struct file_magic {
>>     macho_universal_binary,   ///< Mach-O universal binary
>>     coff_object,              ///< COFF object file
>>     pecoff_executable,        ///< PECOFF executable file
>>-    windows_resource,         ///< Windows compiled resource file (.rc)
>>+    windows_resource          ///< Windows compiled resource file (.rc)
>>   };
>>
>>   bool is_object() const {
>>
>>
>>_______________________________________________
>>llvm-commits mailing list
>>llvm-commits at cs.uiuc.edu
>>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
>
>_______________________________________________
>llvm-commits mailing list
>llvm-commits at cs.uiuc.edu
>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>




More information about the llvm-commits mailing list