TableGen generates an enum to name Schedule Model
Jakob Stoklund Olesen
stoklund at 2pi.dk
Mon Jul 8 20:47:00 PDT 2013
On Jul 8, 2013, at 6:02 PM, Sean Silva <silvas at purdue.edu> wrote:
> Three tiny nits:
>
> +Instructions Itinerary can be queried using MCDesc::getSchedClass() ; the value
> +can be named by an enum generated by Tablegen in the namespace XXXSCHED ;
> +the name of the schedule classes are the same as provided in XXXSchedule.td plus
> +a default NoIntinerary class.
>
> These semicolons should be periods. Also, please capitalize the "g" in TableGen. Also, I think you mean "Instruction itineraries" and not "Instructions Itinerary".
>
> Other than that, LGTM. Jakob, does this look good to you?
I am having trouble understanding that prose, it is possible that punctuation would help.
Why does this need to be hidden away in a separate namespace and requiring XXXGenInstrInfo.inc? Is it going to collide with anything in the normal target namespace?
/jakob
More information about the llvm-commits
mailing list