TableGen generates an enum to name Schedule Model

[Vincent Lejeune]

I put the schedule class names is the same namespace with this updated patch.
I put them in XXXGenInstrInfo.inc because the schedule class is an instruction info,
every instruction has a SchedClass id, but there was no "name" attached to it.
My previous attempt using SubTarget was a bit akward, I assumed that the sched class id
depended on the subtarget but in fact sched classes are shared between subtargets.



----- Mail original -----
> De : Jakob Stoklund Olesen <stoklund at 2pi.dk>
> À : Sean Silva <silvas at purdue.edu>
> Cc : Vincent Lejeune <vljn at ovi.com>; "llvm-commits at cs.uiuc.edu" <llvm-commits at cs.uiuc.edu>
> Envoyé le : Mardi 9 juillet 2013 5h47
> Objet : Re: TableGen generates an enum to name Schedule Model
> 
> 
> On Jul 8, 2013, at 6:02 PM, Sean Silva <silvas at purdue.edu> wrote:
> 
>>  Three tiny nits:
>> 
>>  +Instructions Itinerary can be queried using MCDesc::getSchedClass() ; the 
> value
>>  +can be named by an enum generated by Tablegen in the namespace XXXSCHED ;
>>  +the name of the schedule classes are the same as provided in 
> XXXSchedule.td plus
>>  +a default NoIntinerary class.
>> 
>>  These semicolons should be periods. Also, please capitalize the 
> "g" in TableGen. Also, I think you mean "Instruction 
> itineraries" and not "Instructions Itinerary".
>> 
>>  Other than that, LGTM. Jakob, does this look good to you?
> 
> I am having trouble understanding that prose, it is possible that punctuation 
> would help.
> 
> Why does this need to be hidden away in a separate namespace and requiring 
> XXXGenInstrInfo.inc? Is it going to collide with anything in the normal target 
> namespace?
> 
> /jakob
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-TableGen-Enumerate-Schedule-Model-too.patch
Type: text/x-patch
Size: 2063 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130709/ae8e3d30/attachment.bin>