TableGen generates an enum to name Schedule Model

Sean Silva silvas at purdue.edu
Mon Jul 8 18:02:14 PDT 2013


Three tiny nits:

+Instructions Itinerary can be queried using MCDesc::getSchedClass() ; the
value
+can be named by an enum generated by Tablegen in the namespace XXXSCHED ;
+the name of the schedule classes are the same as provided in
XXXSchedule.td plus
+a default NoIntinerary class.

These semicolons should be periods. Also, please capitalize the "g" in
TableGen. Also, I think you mean "Instruction itineraries" and not
"Instructions Itinerary".

Other than that, LGTM. Jakob, does this look good to you?

-- Sean Silva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130708/10ec2b7a/attachment.html>


More information about the llvm-commits mailing list