TableGen generates an enum to name Schedule Model

Vincent Lejeune vljn at ovi.com
Mon Jul 8 08:08:35 PDT 2013


Thank for your review,

I moved the code to InstrInfoEmitter.cpp (makes more sense) and added documentation in the attached patch.

Vincent





>________________________________
> De : Sean Silva <silvas at purdue.edu>
>À : Vincent Lejeune <vljn at ovi.com> 
>Cc : "llvm-commits at cs.uiuc.edu" <llvm-commits at cs.uiuc.edu> 
>Envoyé le : Lundi 1 juillet 2013 21h56
>Objet : Re: TableGen generates an enum to name Schedule Model
> 
>
>
>+  for (unsigned j = 0, M = SchedModels.numInstrSchedClasses(); j < M; ++j) {
>
>
>
>Can you please use consistent naming here?
>
>
>Also, please add documentation for this change to <http://llvm.org/docs/WritingAnLLVMBackend.html> (docs/WritingAnLLVMBackend.rst).
>
>
>-- Sean Silva
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130708/7b9a0f94/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-TableGen-Enumerate-Schedule-Model-too.patch
Type: text/x-patch
Size: 2138 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130708/7b9a0f94/attachment.bin>


More information about the llvm-commits mailing list