<html><body><div style="color:#000; background-color:#fff; font-family:times new roman, new york, times, serif;font-size:12pt">Thank for your review,<br><br>I moved the code to InstrInfoEmitter.cpp (makes more sense) and added documentation in the attached patch.<br><br>Vincent<br><div><span><br></span></div><div><br><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; margin-top: 5px; padding-left: 5px;"> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div dir="ltr"> <hr size="1"> <font size="2" face="Arial"> <b><span style="font-weight:bold;">De :</span></b> Sean Silva <silvas@purdue.edu><br> <b><span style="font-weight: bold;">À :</span></b> Vincent Lejeune <vljn@ovi.com> <br><b><span style="font-weight: bold;">Cc :</span></b> "llvm-commits@cs.uiuc.edu"
<llvm-commits@cs.uiuc.edu> <br> <b><span style="font-weight: bold;">Envoyé le :</span></b> Lundi 1 juillet 2013 21h56<br> <b><span style="font-weight: bold;">Objet :</span></b> Re: TableGen generates an enum to name Schedule Model<br> </font> </div> <div class="y_msg_container"><br><div id="yiv5982817288"><div dir="ltr">+ for (unsigned j = 0, M = SchedModels.numInstrSchedClasses(); j < M; ++j) {<br><div><br></div><div style="">Can you please use consistent naming here?</div><div style=""><br></div><div style="">Also, please add documentation for this change to <<a rel="nofollow" target="_blank" href="http://llvm.org/docs/WritingAnLLVMBackend.html">http://llvm.org/docs/WritingAnLLVMBackend.html</a>> (docs/WritingAnLLVMBackend.rst).</div>
<div style=""><br></div><div style="">-- Sean Silva</div></div></div><br><br></div> </div> </div> </blockquote></div> </div></body></html>