[PATCH] [lld][PECOFF] Support IMAGE_REL_I386_DIR32 relocation.
Rui Ueyama
ruiu at google.com
Fri Jun 14 17:53:57 PDT 2013
================
Comment at: lib/ReaderWriter/PECOFF/WriterPECOFF.cpp:359-360
@@ -324,3 +358,4 @@
virtual void setVirtualAddress(uint32_t rva) {
_sectionHeader.VirtualAddress = rva;
+ for (AtomLayout *layout : _atomLayouts)
----------------
Shankar Kalpathi Easwaran wrote:
> Doesnt this get truncated ?
What do you mean? Can you elaborate a bit?
================
Comment at: lib/ReaderWriter/PECOFF/WriterPECOFF.cpp:40
@@ -39,2 +39,3 @@
#include "llvm/Support/Debug.h"
+#include "llvm/Support/Endian.h"
#include "llvm/Support/ErrorHandling.h"
----------------
Shankar Kalpathi Easwaran wrote:
> Doesnt windows always use little endian ? Where are you using this ?
Yes Windows is always use little endian. The use of ulittle32 is to produce a proper LE Windows executable when cross building on BE machine.
http://llvm-reviews.chandlerc.com/D985
BRANCH
reloc
ARCANIST PROJECT
lld
More information about the llvm-commits
mailing list