[PATCH] [lld][PECOFF] Support IMAGE_REL_I386_DIR32 relocation.

Shankar Kalpathi Easwaran shankarke at gmail.com
Fri Jun 14 17:47:29 PDT 2013



================
Comment at: lib/ReaderWriter/PECOFF/WriterPECOFF.cpp:359-360
@@ -324,3 +358,4 @@
 
   virtual void setVirtualAddress(uint32_t rva) {
     _sectionHeader.VirtualAddress = rva;
+    for (AtomLayout *layout : _atomLayouts)
----------------
Doesnt this get truncated ?

================
Comment at: lib/ReaderWriter/PECOFF/WriterPECOFF.cpp:40
@@ -39,2 +39,3 @@
 #include "llvm/Support/Debug.h"
+#include "llvm/Support/Endian.h"
 #include "llvm/Support/ErrorHandling.h"
----------------
Doesnt windows always use little endian ? Where are you using this ?


http://llvm-reviews.chandlerc.com/D985

BRANCH
  reloc

ARCANIST PROJECT
  lld



More information about the llvm-commits mailing list