[PATCH] [lld][PECOFF] Support IMAGE_REL_I386_DIR32 relocation.

Shankar Kalpathi Easwaran shankarke at gmail.com
Sat Jun 15 22:05:21 PDT 2013


  LGTM, now.


================
Comment at: lib/ReaderWriter/PECOFF/WriterPECOFF.cpp:359-360
@@ -324,3 +358,4 @@
 
   virtual void setVirtualAddress(uint32_t rva) {
     _sectionHeader.VirtualAddress = rva;
+    for (AtomLayout *layout : _atomLayouts)
----------------
Rui Ueyama wrote:
> Shankar Kalpathi Easwaran wrote:
> > Doesnt this get truncated ?
> What do you mean? Can you elaborate a bit?
nvm, I thought that the virtualAddress field in the section header is 64bit.


http://llvm-reviews.chandlerc.com/D985

BRANCH
  reloc

ARCANIST PROJECT
  lld



More information about the llvm-commits mailing list