[PATCH] Fix for LLVM debug build failure on Windows + MSVC2010SP1

Manish Verma Manish.Verma at arm.com
Fri Jun 7 08:54:30 PDT 2013


Hi Tim,

> I think I'd just enable it globally rather than only on debug builds,
> but if there's a good reason for the restriction are you aware that
> CMake has other profiles? Debug, MinSizeRel, Release and
> RelWithDebInfo by the looks of it.

I don't know much about /bigobj option and there isn't sufficient
information on the web about the negative impact of this option.
MSDN suggests that debug builds to be affected by this error.

http://msdn.microsoft.com/en-us/library/8578y171(v=vs.80).aspx

Therefore, it seemed that the safest change would be add this option
to only debug build which is the one failing at the moment. I was
hoping the community to know more about this option than I do.

> Also, I'm not sure if it's actually cleaner (I'll leave the decision
> to you) but it's possible to directly set the variables
> CMAKE_C_FLAGS_DEBUG (and so on) instead of using the conditionals.
> ccmake's advanced view will show all of those oddities.

Thanks! I'll check if it makes the patch any cleaner.

Manish

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.





More information about the llvm-commits mailing list