[PATCH] Fix for LLVM debug build failure on Windows + MSVC2010SP1

Tim Northover t.p.northover at gmail.com
Fri Jun 7 08:18:46 PDT 2013


Hi Manish,

> Please find attached a patch which fixes the build failure and adds /bigobj
> option to CXX_FLAGS for debug builds.

I think I'd just enable it globally rather than only on debug builds,
but if there's a good reason for the restriction are you aware that
CMake has other profiles? Debug, MinSizeRel, Release and
RelWithDebInfo by the looks of it.

Also, I'm not sure if it's actually cleaner (I'll leave the decision
to you) but it's possible to directly set the variables
CMAKE_C_FLAGS_DEBUG (and so on) instead of using the conditionals.
ccmake's advanced view will show all of those oddities.

Cheers.

Tim



More information about the llvm-commits mailing list