[llvm] r183345 - Add writeAsBinary(raw_ostream &) method to BinaryRef.

[Benjamin Kramer]

On 06.06.2013, at 18:56, Shankar Easwaran <shankare at codeaurora.org> wrote:

> On 6/5/2013 5:59 PM, Sean Silva wrote:
>>  +// Can't find this anywhere else in the codebase (clang has one, but it has
>> +// some baggage). Deduplicate as required.
>> +static bool isHexDigit(uint8_t C) {
>> +  return ('0' <= C && C <= '9') ||
>> +         ('A' <= C && C <= 'F') ||
>> +         ('a' <= C && C <= 'f');
>> +}
>> +
> Can this be inlined in the code using it ? Found only one use.
> 
> If you want to keep this code, should this code be in some support / util library ?

There is isxdigit in ctype.h. It's not dependent on locale settings.

- Ben
> 
> Thanks
> 
> Shankar Easwaran
> 
> -- 
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits