[llvm] r183345 - Add writeAsBinary(raw_ostream &) method to BinaryRef.

Shankar Easwaran shankare at codeaurora.org
Thu Jun 6 09:56:32 PDT 2013


On 6/5/2013 5:59 PM, Sean Silva wrote:
>   
> +// Can't find this anywhere else in the codebase (clang has one, but it has
> +// some baggage). Deduplicate as required.
> +static bool isHexDigit(uint8_t C) {
> +  return ('0' <= C && C <= '9') ||
> +         ('A' <= C && C <= 'F') ||
> +         ('a' <= C && C <= 'f');
> +}
> +
Can this be inlined in the code using it ? Found only one use.

If you want to keep this code, should this code be in some support / 
util library ?

Thanks

Shankar Easwaran

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation




More information about the llvm-commits mailing list