[llvm-commits] [PATCH] YAMLParser diagnostics filename

[Michael Spencer]

On Mon, Nov 19, 2012 at 11:59 AM, Kim Gräsman <kim.grasman at gmail.com> wrote:
> On Mon, Nov 19, 2012 at 8:45 PM, Michael Spencer <bigcheesegs at gmail.com> wrote:
>>
>> +  /// @brief This makes a copy of \a Input.
>>
>> This is not accurate. Input is copied by value, but this comment
>> implies that the string that Input references is copied. This should
>> state that Stream keeps a reference to the string.
>
> Oh! I misread the implementation of GetNamedBuffer -- it copies the
> buffer name, but not the contents.
>
> Thanks for catching that,
> - Kim

Just one more change and it's good. Don't copy documentation to both
the header and definition. In this case it should only be in the
header.

With that change it's fine to commit. I can't really commit it now as
I'm traveling and don't have everything setup.


- Michael Spencer