[llvm-commits] [PATCH] YAMLParser diagnostics filename

Kim Gräsman kim.grasman at gmail.com
Mon Nov 19 12:52:55 PST 2012


On Mon, Nov 19, 2012 at 9:42 PM, Michael Spencer <bigcheesegs at gmail.com> wrote:
>
> Just one more change and it's good. Don't copy documentation to both
> the header and definition. In this case it should only be in the
> header.

The comments apply to two different classes (Stream in the header and
Scanner in the .cpp), and I saw Scanner had some comments already, so
I figured I might as well expand on them.

> With that change it's fine to commit. I can't really commit it now as
> I'm traveling and don't have everything setup.

OK, patch without doc comments on Scanner attached.

Thanks,
- Kim
-------------- next part --------------
A non-text attachment was scrubbed...
Name: YAMLParser-diag-filename.patch
Type: application/octet-stream
Size: 3898 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121119/07eb6dde/attachment.obj>


More information about the llvm-commits mailing list