[llvm-commits] [PATCH] YAMLParser diagnostics filename

[Kim Gräsman]

On Mon, Nov 19, 2012 at 8:45 PM, Michael Spencer <bigcheesegs at gmail.com> wrote:
>
> +  /// @brief This makes a copy of \a Input.
>
> This is not accurate. Input is copied by value, but this comment
> implies that the string that Input references is copied. This should
> state that Stream keeps a reference to the string.

Oh! I misread the implementation of GetNamedBuffer -- it copies the
buffer name, but not the contents.

Thanks for catching that,
- Kim
-------------- next part --------------
A non-text attachment was scrubbed...
Name: YAMLParser-diag-filename-comment.patch
Type: application/octet-stream
Size: 4083 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121119/bfb660a4/attachment.obj>