[llvm-commits] DependenceAnalysis patch

[Preston Briggs]

Thanks Benjamin.

I'm not sure how to make smaller patches when so many test cases are
involved.
I seems like the tests must change in sync with with the code.
Fortunately, most patches don't change all the test cases; this one was
exceptional.

Preston



On Tue, Nov 13, 2012 at 4:15 AM, Benjamin Kramer <benny.kra at gmail.com>wrote:

>
> On 07.11.2012, at 21:51, Preston Briggs <preston.briggs at gmail.com> wrote:
>
> > Here's a patch that covers the problems reported by Chandler last week.
> > It checks the base pointer of each GEP to be sure they are loop
> invariant. The patch also updates the -analyze functionality so that all
> pairs of memory references are tested. Finally, all the test cases have
> been updated.
> >
> > I haven't yet updated DA to analyze pairs of pointer dereferences. I
> wanted to get the initial correction in place first. I also expect that
> analyzer pointer derefs will benefit from delinearization and am hoping it
> gets incorporated soon.
> >
> > If someone could review this change and check it in, if appropriate, I'd
> be obliged.
>
> Hi Preston,
>
> Patch looks good, however, please send changes like this in smaller,
> incremental patches. A 300 KB diff
> is hard to review, especially when there are different changes intertwined.
>
> I went ahead and committed the test case fixes along with the change to
> dump all pairs in r167827. The remaining bits are in the attached file, I'd
> like to have a second pair of eyes looking over it before it goes in.
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121113/6b112d09/attachment.html>