[llvm-commits] DependenceAnalysis patch

[Benjamin Kramer]

On 07.11.2012, at 21:51, Preston Briggs <preston.briggs at gmail.com> wrote:

> Here's a patch that covers the problems reported by Chandler last week.
> It checks the base pointer of each GEP to be sure they are loop invariant. The patch also updates the -analyze functionality so that all pairs of memory references are tested. Finally, all the test cases have been updated.
> 
> I haven't yet updated DA to analyze pairs of pointer dereferences. I wanted to get the initial correction in place first. I also expect that analyzer pointer derefs will benefit from delinearization and am hoping it gets incorporated soon.
> 
> If someone could review this change and check it in, if appropriate, I'd be obliged.

Hi Preston,

Patch looks good, however, please send changes like this in smaller, incremental patches. A 300 KB diff 
is hard to review, especially when there are different changes intertwined.

I went ahead and committed the test case fixes along with the change to dump all pairs in r167827. The remaining bits are in the attached file, I'd like to have a second pair of eyes looking over it before it goes in.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: da-split.patch
Type: application/octet-stream
Size: 13124 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121113/3fce4690/attachment.obj>