[llvm-commits] [PATCH][Review Requested] Fix incorrect scheduling of inline assembly referencing memory

Villmow, Micah Micah.Villmow at amd.com
Fri Oct 26 15:35:52 PDT 2012


Can you add a comment in the source on why this check is needed, other than that it looks fine to me.

Micah

From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Gurd, Preston
Sent: Friday, October 26, 2012 3:27 PM
To: llvm-commits at cs.uiuc.edu
Subject: [llvm-commits] [PATCH][Review Requested] Fix incorrect scheduling of inline assembly referencing memory

Here is a patch which fixes the problem with the Post RA scheduler generating an incorrect instruction sequence due to it not being aware that an inline assembly instruction may reference memory. This patch fixes the problem by causing the scheduler to always assume that any inline assembly code instruction could touch memory. This is necessary because the internal representation of the inline instruction does not include any information about memory accesses.

This should fix PR13504.

The patch also includes a test case.

Please review!

--
Preston Gurd <preston.gurd at intel.com<mailto:preston.gurd at intel.com>>
  Intel Waterloo
  SSG/DPD/ECDL/DMP

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121026/5e47720e/attachment.html>


More information about the llvm-commits mailing list