[llvm-commits] [PATCH] Fix shift immediate operand for ARM instruction ADR

[Renato Golin]

On 31 July 2012 18:17, Jiangning Liu <jiangning.liu at arm.com> wrote:
> Renato,
>
> It's impossible to not be an immediate because isAdrLabel() already checked
> this.

Thought so. ;)

Now, the test is redundant:

if (isImm() && !isa<MCConstantExpr>(getImm())) {

should be:

if (!isa<MCConstantExpr>(getImm())) {

since you're already asserting for immediate.

Thanks!

-- 
cheers,
--renato

http://systemcall.org/