[llvm-commits] [PATCH] Fix shift immediate operand for ARM instruction ADR

[Jiangning Liu]

Renato,

It's impossible to not be an immediate because isAdrLabel() already checked
this.

Anyway, patch is updated as attached to address both of the issues you
mentioned.

Thanks,
-Jiangning

> -----Original Message-----
> From: rengolin at gmail.com [mailto:rengolin at gmail.com] On Behalf Of Renato
> Golin
> Sent: Monday, July 30, 2012 10:04 PM
> To: Jiangning Liu
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm-commits] [PATCH] Fix shift immediate operand for ARM
> instruction ADR
> 
> On 30 July 2012 12:29, Jiangning Liu <jiangning.liu at arm.com> wrote:
> > This patch is to fix http://llvm.org/bugs/show_bug.cgi?id=13241.
> 
> Hi Jiangning,
> 
> In addAdrLabelOperands(), is it possible to not be an immediate, so the
> dyn_cast will try to cast a NULL value? An "assert(isImm())" or "if
> (!isImm()) return;" would be nice.
> 
> In getT2AdrLabelOpValue(), and "else if (Val < 0) {" would avoid the
> extra unnecessary check when Val == INT32_MIN.
> 
> Rest looks ok.
> 
> --
> cheers,
> --renato
> 
> http://systemcall.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: adr_2.patch
Type: application/octet-stream
Size: 9184 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120801/d01bbead/attachment.obj>