[llvm-commits] [PATCH] Fix shift immediate operand for ARM instruction ADR

[Jiangning Liu]

> -----Original Message-----
> From: rengolin at gmail.com [mailto:rengolin at gmail.com] On Behalf Of Renato
> Golin
> Sent: Wednesday, August 01, 2012 1:35 AM
> To: Jiangning Liu
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm-commits] [PATCH] Fix shift immediate operand for ARM
> instruction ADR
> 
> On 31 July 2012 18:17, Jiangning Liu <jiangning.liu at arm.com> wrote:
> > Renato,
> >
> > It's impossible to not be an immediate because isAdrLabel() already
> > checked this.
> 
> Thought so. ;)
> 
> Now, the test is redundant:
> 
> if (isImm() && !isa<MCConstantExpr>(getImm())) {
> 
> should be:
> 
> if (!isa<MCConstantExpr>(getImm())) {
> 
> since you're already asserting for immediate.

Renato,

OK. Updated as attached.

Thanks,
-Jiangning

> 
> Thanks!
> 
> --
> cheers,
> --renato
> 
> http://systemcall.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: adr_3.patch
Type: application/octet-stream
Size: 9173 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120801/0203c4a3/attachment.obj>