[llvm-commits] [llvm] r160796 - in /llvm/trunk: include/llvm/CodeGen/Passes.h include/llvm/InitializePasses.h lib/CodeGen/CMakeLists.txt lib/CodeGen/EarlyIfConversion.cpp lib/CodeGen/MachineTraceMetrics.cpp lib/CodeGen/MachineTraceMetrics.h

[Jakob Stoklund Olesen]

On Jul 27, 2012, at 5:23 PM, Andrew Trick <atrick at apple.com> wrote:

>>> static isFree()... ugh.
>> 
>> static bool isSSANonsense()?
> 
> The name is fine! I was complaining about the "static". I probably would have exposed it in the interface at least to discourage people from copy-pasting it. Although, being in Codegen, Targets can't use it anyway. Maybe one day we'll have to add this to the MachineInstr interface.

Sure, makes sense. It would need a better name that isFree(), though. Something that says isLikelyToBeEliminatedByRAOrNotAtRealInstructionAnyway().

/jakob

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120727/bc631f73/attachment.html>