[llvm-commits] [llvm] r160796 - in /llvm/trunk: include/llvm/CodeGen/Passes.h include/llvm/InitializePasses.h lib/CodeGen/CMakeLists.txt lib/CodeGen/EarlyIfConversion.cpp lib/CodeGen/MachineTraceMetrics.cpp lib/CodeGen/MachineTraceMetrics.h
Andrew Trick
atrick at apple.com
Sat Jul 28 16:02:01 PDT 2012
On Jul 27, 2012, at 8:01 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:
>
> On Jul 27, 2012, at 5:23 PM, Andrew Trick <atrick at apple.com> wrote:
>
>>>> static isFree()... ugh.
>>>
>>> static bool isSSANonsense()?
>>
>> The name is fine! I was complaining about the "static". I probably would have exposed it in the interface at least to discourage people from copy-pasting it. Although, being in Codegen, Targets can't use it anyway. Maybe one day we'll have to add this to the MachineInstr interface.
>
> Sure, makes sense. It would need a better name that isFree(), though. Something that says isLikelyToBeEliminatedByRAOrNotAtRealInstructionAnyway().
>
> /jakob
Transient. Or if you want to be dramatic, Phantom instructions.
Andy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120728/756a0a16/attachment.html>
More information about the llvm-commits
mailing list