[llvm-commits] [llvm] r160796 - in /llvm/trunk: include/llvm/CodeGen/Passes.h include/llvm/InitializePasses.h lib/CodeGen/CMakeLists.txt lib/CodeGen/EarlyIfConversion.cpp lib/CodeGen/MachineTraceMetrics.cpp lib/CodeGen/MachineTraceMetrics.h

[Andrew Trick]

On Jul 27, 2012, at 4:38 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:

>> There's also no reason we shouldn't be able to add blocks, as long as the traces reaching new edges are invalidated first. The current invalidate API isn't quite right for that, because we don't want to invalidate any block-local info. Just something to think about for now.
> 
> Do you mean critical edge splitting?

Sure. That or tail-dup/peeling. I could see TraceMetrics driving any machine CFG transform.

>> static isFree()... ugh.
> 
> static bool isSSANonsense()?

The name is fine! I was complaining about the "static". I probably would have exposed it in the interface at least to discourage people from copy-pasting it. Although, being in Codegen, Targets can't use it anyway. Maybe one day we'll have to add this to the MachineInstr interface.

-Andy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120727/776cd7ff/attachment.html>