[llvm-commits] [PATCH] Fix error propagation in ARMDisassembler.cpp

[Owen Anderson]

Looks great, applied in r137320.

--Owen

On Aug 11, 2011, at 8:48 AM, James Molloy wrote:

> Hi,
>  
> The attached patch improves propagation of decoding errors in ARMDisassembler.cpp. There are many call sites of functions that return a boolean error status that are not checked. This patch fixes that.
>  
> As a result of this patch, the test MC/Disassembler/ARM/invalid-VLDMSDB_UPD-arm.txt now passes, so has been unmarked as XFAIL. It has also stopped many llvm_unreachable() aborts when decoding bad bitpatterns.
>  
> Cheers,
>  
> James
>  
> [Patch really too large to inline. Lots of if (!X) return false’s]
>  
>  
>  
> <ARMDisassembler.cpp.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110811/87ffd22b/attachment.html>