[llvm-commits] [PATCH] Fix error propagation in ARMDisassembler.cpp

[James Molloy]

Hi,

 

The attached patch improves propagation of decoding errors in
ARMDisassembler.cpp. There are many call sites of functions that return a
boolean error status that are not checked. This patch fixes that.

 

As a result of this patch, the test
MC/Disassembler/ARM/invalid-VLDMSDB_UPD-arm.txt now passes, so has been
unmarked as XFAIL. It has also stopped many llvm_unreachable() aborts when
decoding bad bitpatterns.

 

Cheers,

 

James

 

[Patch really too large to inline. Lots of if (!X) return false's]

 

 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110811/d4752fd1/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ARMDisassembler.cpp.patch
Type: application/octet-stream
Size: 25883 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20110811/d4752fd1/attachment.obj>