[llvm-commits] [llvm] r118687 - in /llvm/trunk: include/llvm/Analysis/AliasAnalysis.h lib/Transforms/IPO/FunctionAttrs.cpp

[Duncan Sands]

Hi Dan,

>>> + if (AliasAnalysis::onlyAccessesArgPointees(MRB)) {
>>> + // If the call does access argument pointees, check each argument.
>>> if (MRB& AliasAnalysis::AccessesArguments)
>>
>> Is this second "if" redundant?
>
> No; I've added another helper function for this now.

thanks.  I find it confusing that in onlyAccessesArgPointees, "accesses"
means read-write, while in AccessesArguments, "accesses" means read-only.
How about changing AliasAnalysis::AccessesArguments to ReadsArguments?

Ciao,

Duncan.