[llvm-commits] [llvm] r118687 - in /llvm/trunk: include/llvm/Analysis/AliasAnalysis.h lib/Transforms/IPO/FunctionAttrs.cpp

[Dan Gohman]

On Nov 10, 2010, at 10:00 AM, Duncan Sands <baldrick at free.fr> wrote:

> Hi Dan,
>
>> +  /// onlyAccessesArgPointees - Return true if functions with the  
>> specified
>> +  /// behavior are known to read at most from objects pointed to  
>> by their
>> +  /// pointer-typed arguments (with arbitrary offsets).
>
> can't they also write to objects pointed to by their arguments?

Oops. Fixed.

>
>> +        if (AliasAnalysis::onlyAccessesArgPointees(MRB)) {
>> +          // If the call does access argument pointees, check each  
>> argument.
>>            if (MRB&  AliasAnalysis::AccessesArguments)
>
> Is this second "if" redundant?

No; I've added another helper function for this now.

Dan

>