[llvm-commits] [llvm] r118687 - in /llvm/trunk: include/llvm/Analysis/AliasAnalysis.h lib/Transforms/IPO/FunctionAttrs.cpp

[Dan Gohman]

On Nov 10, 2010, at 12:59 PM, Duncan Sands <baldrick at free.fr> wrote:

> Hi Dan,
>
>>>> + if (AliasAnalysis::onlyAccessesArgPointees(MRB)) {
>>>> + // If the call does access argument pointees, check each  
>>>> argument.
>>>> if (MRB& AliasAnalysis::AccessesArguments)
>>>
>>> Is this second "if" redundant?
>>
>> No; I've added another helper function for this now.
>
> thanks.  I find it confusing that in onlyAccessesArgPointees,  
> "accesses"
> means read-write, while in AccessesArguments, "accesses" means read- 
> only.

"Accesses" was meant to mean read+write in both -- AccessesArguments  
meant loads and stores to argument pointees.

> How about changing AliasAnalysis::AccessesArguments to ReadsArguments?

I've renamed both and updated the comments.  Let me know if the new  
code is unclear.

Dan