[llvm-commits] [patch] AsmParser hook for UseCodeAlign

Rafael Espindola espindola at google.com
Fri Oct 1 12:14:56 PDT 2010


> Comments?

The comment "Return true if a .align directive without a fill value"
is not exactly right. It is used to decide if "optimized nops" should
be used for this section. They will be used if there is not fill or if
the fill is a nop already ((!HasFillExpr ||
Lexer.getMAI().getTextAlignFillValue() == FillExpr)).

Can you also add a test?

OK with those changes.

> Attached is a patch.
> Alternate online view of the patch:
> http://codereview.chromium.org/3595005/show
> - Jan
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>

Thanks,
-- 
Rafael Ávila de Espíndola




More information about the llvm-commits mailing list