[llvm-commits] [patch] AsmParser hook for UseCodeAlign

Jan Voung jvoung at google.com
Thu Sep 30 13:10:40 PDT 2010


Hi all,

I'm looking into the "FIXME: This should be using a target hook" (in
AsmParser.cpp)
for picking fill values (e.g., nops vs zeros) to pad for alignment. There
was a single
case for MachO, so I moved the test to the individual kinds of MCSections.

Not sure of the exact rules on when to use nops and when to fill with
zeros,
but I at least kept the test the same for MachO =)

Comments?

Attached is a patch.
Alternate online view of the patch:
http://codereview.chromium.org/3595005/show

- Jan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100930/1ccc683e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: codealign.patch
Type: text/x-patch
Size: 5071 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100930/1ccc683e/attachment.bin>


More information about the llvm-commits mailing list