[llvm-commits] [patch] AsmParser hook for UseCodeAlign

[Jan Voung]

Thanks for the review Rafael. Attached is a new patch with the fixed comment
plus tests for ELF and COFF.  I think MachO already had a test.

- Jan

(online diff also refreshed w/ updates)

On Fri, Oct 1, 2010 at 12:14 PM, Rafael Espindola <espindola at google.com>wrote:

> > Comments?
>
> The comment "Return true if a .align directive without a fill value"
> is not exactly right. It is used to decide if "optimized nops" should
> be used for this section. They will be used if there is not fill or if
> the fill is a nop already ((!HasFillExpr ||
> Lexer.getMAI().getTextAlignFillValue() == FillExpr)).
>
> Can you also add a test?
>
> OK with those changes.
>
> > Attached is a patch.
> > Alternate online view of the patch:
> > http://codereview.chromium.org/3595005/show
> > - Jan
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
> >
>
> Thanks,
> --
> Rafael Ávila de Espíndola
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101001/bd537500/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: codealign2.patch
Type: text/x-patch
Size: 8447 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101001/bd537500/attachment.bin>